Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vite and (some) otel packages #882

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Jun 13, 2024

Replaces #874

Initially I deleted the viewer pnpm-lock.yaml, because I realized that it shares the frontend's lockfile. But, I'm not sure how deleting it might affect the local-web-app and mabye other stuff.

So, I temporarily used shared-workspace-lockfile=false (which seems to be undocumented. pnpm has not convinced me 😉) in .npmrc to update the viewer lock file, which was waaay out of date 😆.

Copy link

github-actions bot commented Jun 13, 2024

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 49dd192. ± Comparison against base commit 037fb46.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 13, 2024

FW Lite Unit Tests

19 tests  ±0   19 ✅ ±0   4s ⏱️ ±0s
 2 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 49dd192. ± Comparison against base commit 037fb46.

♻️ This comment has been updated with latest results.

@myieye myieye force-pushed the chore/bump-vite-packages branch from 2dd5cae to 49dd192 Compare June 13, 2024 07:57
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@myieye myieye merged commit cb7afea into develop Jun 14, 2024
11 checks passed
@myieye myieye deleted the chore/bump-vite-packages branch June 14, 2024 08:34
@myieye
Copy link
Contributor Author

myieye commented Jun 14, 2024

I'm planning to open a follow up PR that removes the lock file, because that's probably the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants